[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8584) reloadhint for syncprov overlay should default to TRUE



Quanah Gibson-Mount wrote:
> --On Tuesday, February 07, 2017 8:53 AM +0000 Howard Chu <hyc@symas.com> wrote:
>
>
>> The relevant part of the doc is "It must be set TRUE when using the
>> accesslog overlay for delta-based syncrepl support." Otherwise it has no
>> effect, so there is no reason to change it in the default case.
>
> Actually, what the manpage says is:
>
> This option should be set TRUE when working with
> newer releases that properly support this flag. It must  be  set
> TRUE  when  using the accesslog overlay for delta-based syncrepl
> replication support.
>
> So, that clearly states it should *always* be TRUE unless you have a 2.3.11 or
> earlier consumer, which is technically not allowable.  There is zero reason
> for this tunable to exist.  It should be deprecated and the internal code
> changed to simply set the flag to TRUE.  One less item for anyone to have to
> ever deal with is a win.

"when working with newer releases that properly support this flag."

The syncrepl consumer only pays attention to this flag in delta-sync. There is 
no reason to use reloadhint in regular syncrepl. Turning it on by default only 
slows down the refresh negotiation in regular syncrepl.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/