Re: (ITS#8504) LDMB: Return EPIPE from mdb_env_copyfd2 instead abort on SIGPIPE

[lmb@cloudflare.com]

--001a114741aec1bad3053f481b06
Content-Type: text/plain; charset=UTF-8

On 20 October 2016 at 09:35, Hallvard Breien Furuseth <
h.b.furuseth@usit.uio.no> wrote:
>
> Hmm.  Nevermind, it's probably better to leave that to the user.
> It gets ugly for a library to meddle with the current thread's
> signals.  I.e. it must check if SIGPIPE was already pending
> before the call, and don't collect it on EPIPE in that case.
>

Yeah, I agree. Your changes LGTM.

Interesting point re atomic int write, I wasn't entirely sure how mc_error
could be accesses, so I decided to play it safe.

-- 
Lorenz Bauer  |  Systems Engineer
25 Lavington St., London SE1 0NZ

www.cloudflare.com

--001a114741aec1bad3053f481b06
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">=
On 20 October 2016 at 09:35, Hallvard Breien Furuseth <span dir=3D"ltr">&lt=
;<a href=3D"mailto:h.b.furuseth@usit.uio.no"; target=3D"_blank">h.b.furuseth=
@usit.uio.no</a>&gt;</span> wrote:<blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hmm.=C2=A0 Nevermind, it&#39;s probably better to leave that to the user.<b=
r>
It gets ugly for a library to meddle with the current thread&#39;s<br>
signals.=C2=A0 I.e. it must check if SIGPIPE was already pending<br>
before the call, and don&#39;t collect it on EPIPE in that case.<span class=
=3D"HOEnZb"><font color=3D"#888888"><br></font></span></blockquote></div><d=
iv><br></div><div>Yeah, I agree. Your changes LGTM.</div><div><br></div><di=
v>Interesting point re atomic int write, I wasn&#39;t entirely sure how mc_=
error could be accesses, so I decided to play it safe.</div><div><br></div>=
-- <br><div class=3D"gmail_signature" data-smartmail=3D"gmail_signature">Lo=
renz Bauer =C2=A0| =C2=A0Systems Engineer<br>25 Lavington St., London SE1 0=
NZ<br><br><a href=3D"http://www.cloudflare.com"; target=3D"_blank">www.cloud=
flare.com</a></div>
</div></div>

--001a114741aec1bad3053f481b06--