[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8445) LibreSSL v2.4 compile



--001a113eeb0acc108f0535abc1d3
Content-Type: multipart/alternative; boundary=001a113eeb0acc10860535abc1d1

--001a113eeb0acc10860535abc1d1
Content-Type: text/plain; charset=UTF-8

Fixed, attached is a patch.

On Sun, Jun 19, 2016 at 8:02 PM Howard Chu <hyc@symas.com> wrote:

> cpaynetaffe@gmail.com wrote:
> > Full_Name: Connor Taffe
> > Version: master
> > OS: Ubuntu devel
> > URL: ftp://ftp.openldap.org/incoming/
> > Submission from: (NULL) (50.25.160.41)
> >
> >
> > Compiling against LibreSSL v2.4.1 failed linking with SSL_CTX_up_ref and
> > X509_NAME_get0_der undefined. I added checking if
> LIBRESSL_VERSION_NUMBER to the
> > same conditional compilation ifs that are defined for old versions of
> OpenSSL.
> >
> > https://github.com/cptaffe/openldap
>
> Please read the Developer Guidelines. I'm not going to pull an arbitrary
> repo
> to find someone's patch.
>
> http://www.openldap.org/devel/contributing.html
>
> --
>    -- Howard Chu
>    CTO, Symas Corp.           http://www.symas.com
>    Director, Highland Sun     http://highlandsun.com/hyc/
>    Chief Architect, OpenLDAP  http://www.openldap.org/project/
>

--001a113eeb0acc10860535abc1d1
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Fixed, attached is a patch.<br><br><div class=3D"gmail_quo=
te"><div dir=3D"ltr">On Sun, Jun 19, 2016 at 8:02 PM Howard Chu &lt;<a href=
=3D"mailto:hyc@symas.com";>hyc@symas.com</a>&gt; wrote:<br></div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc soli=
d;padding-left:1ex"><a href=3D"mailto:cpaynetaffe@gmail.com"; target=3D"_bla=
nk">cpaynetaffe@gmail.com</a> wrote:<br>
&gt; Full_Name: Connor Taffe<br>
&gt; Version: master<br>
&gt; OS: Ubuntu devel<br>
&gt; URL: <a href=3D"ftp://ftp.openldap.org/incoming/"; rel=3D"noreferrer" t=
arget=3D"_blank">ftp://ftp.openldap.org/incoming/</a><br>
&gt; Submission from: (NULL) (50.25.160.41)<br>
&gt;<br>
&gt;<br>
&gt; Compiling against LibreSSL v2.4.1 failed linking with SSL_CTX_up_ref a=
nd<br>
&gt; X509_NAME_get0_der undefined. I added checking if LIBRESSL_VERSION_NUM=
BER to the<br>
&gt; same conditional compilation ifs that are defined for old versions of =
OpenSSL.<br>
&gt;<br>
&gt; <a href=3D"https://github.com/cptaffe/openldap"; rel=3D"noreferrer" tar=
get=3D"_blank">https://github.com/cptaffe/openldap</a><br>
<br>
Please read the Developer Guidelines. I&#39;m not going to pull an arbitrar=
y repo<br>
to find someone&#39;s patch.<br>
<br>
<a href=3D"http://www.openldap.org/devel/contributing.html"; rel=3D"noreferr=
er" target=3D"_blank">http://www.openldap.org/devel/contributing.html</a><b=
r>
<br>
--<br>
=C2=A0 =C2=A0-- Howard Chu<br>
=C2=A0 =C2=A0CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a hr=
ef=3D"http://www.symas.com"; rel=3D"noreferrer" target=3D"_blank">http://www=
.symas.com</a><br>
=C2=A0 =C2=A0Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://hi=
ghlandsun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun=
.com/hyc/</a><br>
=C2=A0 =C2=A0Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap=
.org/project/" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org=
/project/</a><br>
</blockquote></div></div>

--001a113eeb0acc10860535abc1d1--
--001a113eeb0acc108f0535abc1d3
Content-Type: text/x-patch; charset=US-ASCII; name="fix-libressl.patch"
Content-Disposition: attachment; filename="fix-libressl.patch"
Content-Transfer-Encoding: base64
Content-ID: <1556b74d65e98bc2a261>
X-Attachment-Id: 1556b74d65e98bc2a261

RnJvbSBkNWRjNTcwMTJkYmYwMGM3NWVkY2ZmNjM2ODdlZmIwNjhjZWU0NDQ4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDb25ub3IgVGFmZmUgPGNwYXluZXRhZmZlQGdtYWlsLmNvbT4K
RGF0ZTogU3VuLCAxOSBKdW4gMjAxNiAwMzo0NToyOSAtMDUwMApTdWJqZWN0OiBbUEFUQ0ggMS8y
XSBSZW1vdmUgZnVuY3Rpb24gY2FsbHMgZm9yIExpYnJlU1NMIGNvbXBhdGFiaWxpdHkKClJlbW92
ZWQgY2FsbHMgdG8gWDUwOV9OQU1FX2dldDBfZGVyIGFuZCBTU0xfQ0VSVF91cF9yZWYgd2hlbgpM
SUJSRVNTTF9WRVJTSU9OX05VTUJFUiBpcyBkZWZpbmVkLgpVc2VzIHNhbWUgY29tcGF0YWJpbGl0
eSBtZWNoYW5pc20gYXMgZm9yIG9sZCB2ZXJzaW9ucyBvZiBPcGVuU1NMLgotLS0KIGxpYnJhcmll
cy9saWJsZGFwL3Rsc19vLmMgfCAxMSArKysrKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDcgaW5z
ZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saWJyYXJpZXMvbGlibGRh
cC90bHNfby5jIGIvbGlicmFyaWVzL2xpYmxkYXAvdGxzX28uYwppbmRleCBlMWI3ZDQ4Li44Zjk1
ZTRiIDEwMDY0NAotLS0gYS9saWJyYXJpZXMvbGlibGRhcC90bHNfby5jCisrKyBiL2xpYnJhcmll
cy9saWJsZGFwL3Rsc19vLmMKQEAgLTE4OSw3ICsxODksOCBAQCBzdGF0aWMgdm9pZAogdGxzb19j
dHhfcmVmKCB0bHNfY3R4ICpjdHggKQogewogCXRsc29fY3R4ICpjID0gKHRsc29fY3R4ICopY3R4
OwotI2lmIE9QRU5TU0xfVkVSU0lPTl9OVU1CRVIgPCAweDEwMTAwMDAwCisvLyBMaWJyZVNTTCAo
YXMgb2YgdjIuNC4xKSAgZG9lc24ndCBkZWZpbmUgU1NMX0NUWF91cF9yZWYKKyNpZiBPUEVOU1NM
X1ZFUlNJT05fTlVNQkVSIDwgMHgxMDEwMDAwMCB8fCBMSUJSRVNTTF9WRVJTSU9OX05VTUJFUgog
I2RlZmluZQlTU0xfQ1RYX3VwX3JlZihjdHgpCUNSWVBUT19hZGQoICYoY3R4LT5yZWZlcmVuY2Vz
KSwgMSwgQ1JZUFRPX0xPQ0tfU1NMX0NUWCApCiAjZW5kaWYKIAlTU0xfQ1RYX3VwX3JlZiggYyAp
OwpAQCAtNDczLDE0ICs0NzQsMTUgQEAgdGxzb19zZXNzaW9uX215X2RuKCB0bHNfc2Vzc2lvbiAq
c2Vzcywgc3RydWN0IGJlcnZhbCAqZGVyX2RuICkKIAlpZiAoIXgpIHJldHVybiBMREFQX0lOVkFM
SURfQ1JFREVOVElBTFM7CiAJCiAJeG4gPSBYNTA5X2dldF9zdWJqZWN0X25hbWUoeCk7Ci0jaWYg
T1BFTlNTTF9WRVJTSU9OX05VTUJFUiA8IDB4MTAxMDAwMDAKKy8vIExpYnJlU1NMIChhcyBvZiB2
Mi40LjEpIGRvZXNuJ3QgZGVmaW5lIFg1MDlfTkFNRV9nZXQwX2RlcgorI2lmIE9QRU5TU0xfVkVS
U0lPTl9OVU1CRVIgPCAweDEwMTAwMDAwIHx8IExJQlJFU1NMX1ZFUlNJT05fTlVNQkVSCiAJZGVy
X2RuLT5idl9sZW4gPSBpMmRfWDUwOV9OQU1FKCB4biwgTlVMTCApOwogCWRlcl9kbi0+YnZfdmFs
ID0geG4tPmJ5dGVzLT5kYXRhOwogI2Vsc2UKIAl7CiAJCXNpemVfdCBsZW4gPSAwOwogCQlkZXJf
ZG4tPmJ2X3ZhbCA9IE5VTEw7Ci0JCVg1MDlfTkFNRV9nZXQwX2RlciggKGNvbnN0IHVuc2lnbmVk
IGNoYXIgKiopJmRlcl9kbi0+YnZfdmFsLCAmbGVuLCB4biApOworCVg1MDlfTkFNRV9nZXQwX2Rl
ciggKGNvbnN0IHVuc2lnbmVkIGNoYXIgKiopJmRlcl9kbi0+YnZfdmFsLCAmbGVuLCB4biApOwog
CQlkZXJfZG4tPmJ2X2xlbiA9IGxlbjsKIAl9CiAjZW5kaWYKQEAgLTUwOSw3ICs1MTEsOCBAQCB0
bHNvX3Nlc3Npb25fcGVlcl9kbiggdGxzX3Nlc3Npb24gKnNlc3MsIHN0cnVjdCBiZXJ2YWwgKmRl
cl9kbiApCiAJCXJldHVybiBMREFQX0lOVkFMSURfQ1JFREVOVElBTFM7CiAKIAl4biA9IFg1MDlf
Z2V0X3N1YmplY3RfbmFtZSh4KTsKLSNpZiBPUEVOU1NMX1ZFUlNJT05fTlVNQkVSIDwgMHgxMDEw
MDAwMAorLy8gTGlicmVTU0wgKGFzIG9mIHYuMi40LjEpIGRvZXNuJ3QgZGVmaW5lIFg1MDlfTkFN
RV9nZXQwX2RlcgorI2lmIE9QRU5TU0xfVkVSU0lPTl9OVU1CRVIgPCAweDEwMTAwMDAwIHx8IExJ
QlJFU1NMX1ZFUlNJT05fTlVNQkVSCiAJZGVyX2RuLT5idl9sZW4gPSBpMmRfWDUwOV9OQU1FKCB4
biwgTlVMTCApOwogCWRlcl9kbi0+YnZfdmFsID0geG4tPmJ5dGVzLT5kYXRhOwogI2Vsc2UKLS0g
CjIuOS4wCgoKRnJvbSA0NWZmMTQyODA5YjdlZGVjZDlmMTU0OTA1MmVjNWE3NjQ4ZGY4ZDBkIE1v
biBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDb25ub3IgVGFmZmUgPGNwYXluZXRhZmZlQGdt
YWlsLmNvbT4KRGF0ZTogU3VuLCAxOSBKdW4gMjAxNiAyMDoyNzoxNyAtMDUwMApTdWJqZWN0OiBb
UEFUQ0ggMi8yXSBGaXggd2hpdGVzcGFjZSBpbmFkdmVydGVudGx5IGZ1Y2tlZCB1cAoKLS0tCiBs
aWJyYXJpZXMvbGlibGRhcC90bHNfby5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0
aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlicmFyaWVzL2xpYmxkYXAvdGxz
X28uYyBiL2xpYnJhcmllcy9saWJsZGFwL3Rsc19vLmMKaW5kZXggOGY5NWU0Yi4uMDk0ODZlNyAx
MDA2NDQKLS0tIGEvbGlicmFyaWVzL2xpYmxkYXAvdGxzX28uYworKysgYi9saWJyYXJpZXMvbGli
bGRhcC90bHNfby5jCkBAIC00ODIsNyArNDgyLDcgQEAgdGxzb19zZXNzaW9uX215X2RuKCB0bHNf
c2Vzc2lvbiAqc2Vzcywgc3RydWN0IGJlcnZhbCAqZGVyX2RuICkKIAl7CiAJCXNpemVfdCBsZW4g
PSAwOwogCQlkZXJfZG4tPmJ2X3ZhbCA9IE5VTEw7Ci0JWDUwOV9OQU1FX2dldDBfZGVyKCAoY29u
c3QgdW5zaWduZWQgY2hhciAqKikmZGVyX2RuLT5idl92YWwsICZsZW4sIHhuICk7CisJCVg1MDlf
TkFNRV9nZXQwX2RlciggKGNvbnN0IHVuc2lnbmVkIGNoYXIgKiopJmRlcl9kbi0+YnZfdmFsLCAm
bGVuLCB4biApOwogCQlkZXJfZG4tPmJ2X2xlbiA9IGxlbjsKIAl9CiAjZW5kaWYKLS0gCjIuOS4w
Cgo=
--001a113eeb0acc108f0535abc1d3--