[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8270) win32: fix conversion error

2015-10-20 23:09 GMT+03:00 <hyc@symas.com>:
> nacho.resa@gmail.com wrote:
> > --047d7bb03a5ac118d20522842ead
> > Content-Type: text/plain; charset=UTF-8
> >
> > So I took another closer look at this issue and I went for this possible
> > solution:
> > https://github.com/nice-software/lmdb/commit/03987789735141dc68ae8b2d0e5ad52d82cc80d0
> That looks OK.
> > Basically it errors out because MSVC needs stdcall on that method.
> You realize of course, that this change actually has no effect on the code
> here? stdcall uses Pascal argument order instead of C order but it's moot
> since the function only has 1 argument.

Oops, sorry (dummy gmail...).

No, there is another important difference:
cdecl = the caller is responsible to clean stack from args (e.g. addl esp, N);
stdcall = the callee is responsible to clean stack from args (e.g. retn N);