[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8270) win32: fix conversion error



Ignacio Casal Quinteiro wrote:
> I am ok not fixing the MSVC warnings because it is picky even though some of
> them might make sense even for mingw, but in this case it is an error and this
> really small change enable msvc to build without errors. Can't you reconsider
> the change? Specially since it will build fine with mingw as well.

No, since it will break Unix builds.
>
> On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <hyc@symas.com
> <mailto:hyc@symas.com>> wrote:
>
>     nacho.resa@gmail.com <mailto:nacho.resa@gmail.com> wrote:
>
>         Full_Name: Ignacio Casal Quinteiro
>         Version:
>         OS: Windows 7
>         URL: ftp://ftp.openldap.org/incoming/
>         Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa)
>
>
>         https://github.com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a898a4f155e3dce
>
>
>     I see no error when compiling with gcc -Wall. Closing this ITS.
>
>     --
>        -- Howard Chu
>        CTO, Symas Corp. http://www.symas.com
>        Director, Highland Sun http://highlandsun.com/hyc/
>        Chief Architect, OpenLDAP http://www.openldap.org/project/
>
>
>
>
> --
> Ignacio Casal Quinteiro


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/