[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
Re: (ITS#8270) win32: fix conversion error
--047d7bfd0df8f33b1905226f06af
Content-Type: text/plain; charset=UTF-8
I am ok not fixing the MSVC warnings because it is picky even though some
of them might make sense even for mingw, but in this case it is an error
and this really small change enable msvc to build without errors. Can't you
reconsider the change? Specially since it will build fine with mingw as
well.
On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <hyc@symas.com> wrote:
> nacho.resa@gmail.com wrote:
>
>> Full_Name: Ignacio Casal Quinteiro
>> Version:
>> OS: Windows 7
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa)
>>
>>
>>
>> https://github.com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a898a4f155e3dce
>>
>>
>> I see no error when compiling with gcc -Wall. Closing this ITS.
>
> --
> -- Howard Chu
> CTO, Symas Corp. http://www.symas.com
> Director, Highland Sun http://highlandsun.com/hyc/
> Chief Architect, OpenLDAP http://www.openldap.org/project/
>
--
Ignacio Casal Quinteiro
--047d7bfd0df8f33b1905226f06af
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">I am ok not fixing the MSVC warnings because it is picky e=
ven though some of them might make sense even for mingw, but in this case i=
t is an error and this really small change enable msvc to build without err=
ors. Can't you reconsider the change? Specially since it will build fin=
e with mingw as well.<br></div><div class=3D"gmail_extra"><br><div class=3D=
"gmail_quote">On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <span dir=3D"ltr"=
><<a href=3D"mailto:hyc@symas.com"; target=3D"_blank">hyc@symas.com</a>&g=
t;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0=
.8ex;border-left:1px #ccc solid;padding-left:1ex"><a href=3D"mailto:nacho.=
resa@gmail.com" target=3D"_blank">nacho.resa@gmail.com</a> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
Full_Name: Ignacio Casal Quinteiro<br>
Version:<br>
OS: Windows 7<br>
URL: <a href=3D"ftp://ftp.openldap.org/incoming/"; rel=3D"noreferrer" target=
=3D"_blank">ftp://ftp.openldap.org/incoming/</a><br>
Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa)<br>
<br>
<br>
<a href=3D"https://github.com/nice-software/lmdb/commit/076281a2c03356667fc=
a7cce1a898a4f155e3dce" rel=3D"noreferrer" target=3D"_blank">https://github.=
com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a898a4f155e3dce</a><=
br>
<br>
<br>
</blockquote>
I see no error when compiling with gcc -Wall. Closing this ITS.<span class=
=3D"HOEnZb"><font color=3D"#888888"><br>
<br>
-- <br>
=C2=A0 -- Howard Chu<br>
=C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"=
http://www.symas.com"; rel=3D"noreferrer" target=3D"_blank">http://www.symas=
.com</a><br>
=C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland=
sun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun.com/h=
yc/</a><br>
=C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p=
roject/" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org/proje=
ct/</a><br>
</font></span></blockquote></div><br><br clear=3D"all"><br>-- <br><div clas=
s=3D"gmail_signature">Ignacio Casal Quinteiro</div>
</div>
--047d7bfd0df8f33b1905226f06af--