[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8129) ignored config variable autocommit for back-sql

daniel.chobe@dimensiondata.com wrote:
> Full_Name: Daniel Chobe
> Version: 2.4.40
> OS: Linux
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (217.111.74.244)
>
>
> This bug is related to ITS#6613. In this bug a new configvariable named
> autocommit was introduced. But the flagmask in config.c was wrong, so setting
> this config variable has no influence to the behavior of the slapd.
>
> The Patch is very simply replace SQL_AUTOCOMMIT with BSQL_AUTOCOMMIT.

Thanks for the report, fixed in git master.
>
>
> diff -rupN 1/servers/slapd/back-sql/config.c 2/servers/slapd/back-sql/config.c
> --- 1/servers/slapd/back-sql/config.c	2013-11-15 04:31:27.000000000 +0100
> +++ 2/servers/slapd/back-sql/config.c	2015-05-05 14:51:43.161310554 +0200
> @@ -210,7 +210,7 @@ static ConfigTable sqlcfg[] = {
>   			"DESC 'Quoting char of the aliasing keyword' "
>   			"SYNTAX OMsDirectoryString SINGLE-VALUE )", NULL, NULL },
>   	{ "autocommit", "yes|no", 2, 2, 0,
> -		ARG_ON_OFF|ARG_MAGIC|SQL_TOCOCOMMIT, (void *)sql_cf_gen,
> +		ARG_ON_OFF|ARG_MAGIC|BSQL_AUTOCOMMIT, (void *)sql_cf_gen,
>   		"( OLcfgDbAt:6.45 NAME 'olcSqlAutocommit' "
>   			"SYNTAX OMsBoolean SINGLE-VALUE )", NULL, NULL },
>   	{ NULL, NULL, 0, 0, 0, ARG_IGNORED,
>
>


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/