[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8105) [PATCH] slaptest doesn't convert perlModuleConfig lines

Jan Synacek wrote:
> Howard Chu <hyc@symas.com> writes:
>> jsynacek@redhat.com wrote:
>>> Full_Name: Jan Synacek
>>> Version: master
>>> OS: GNU/Linux
>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150415-back-perl-correctly-convert-perlModuleConfig.patch
>>> Submission from: (NULL) (
>>> When using the perl backend, slaptest doesn't convert perlModuleConfig lines
>>> from slapd.conf to slapd.d.
>>> A simple reproducer can be found at
>>> https://jsynacek.fedorapeople.org/openldap/back-perl.sh
>> Thanks, added to git master
> I misunderstood the semantics of perlModuleConfig when given multiple
> arguments, so the patch isn't quite correct. I'm sorry for the
> confusion. The fix can be found at:
> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150424-More-for-ITS-8105.patch
> Please note that I'm not aware of any internal functions that I can use
> to flatten a list of strings. If there are some, or if there is a better
> way to fix the issue, please advice, I'll simplify the patch.
Hi Jan, there's no need to muck with the list of strings, just use 
c->line instead of c->argv.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/