[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8062) Assertion 'IS_LEAF(mp)' failed in mdb_cursor_next()



--001a113602ac48c9b00511a317b0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hm, in some case valgrind was reported as I noticed, sure 101%.

Leonid
18.03.2015 23:12 =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=
=B5=D0=BB=D1=8C "Howard Chu" <hyc@symas.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=
=D0=B0=D0=BB:

> leo@yuriev.ru wrote:
>
>> As far as I remember this was fixed in ReOpenLDAP at January.
>> Valgrind was reporting 'using uninitialized'.
>>
>
> Not happening here. mdb_cursor_first() always initializes mc_ki.
>
>>
>> Leonid.
>>
>> @@ -7301,6 +7551,7 @@ mdb_cursor_init(MDB_cursor *mc, MDB_txn *txn,
>> MDB_dbi dbi, MDB_xcursor *mx)
>>           mc->mc_top =3D 0;
>>           mc->mc_pg[0] =3D 0;
>>           mc->mc_flags =3D 0;
>> +       mc->mc_ki[0] =3D 0;
>>           if (txn->mt_dbs[dbi].md_flags & MDB_DUPSORT) {
>>                   mdb_tassert(txn, mx !=3D NULL);
>>                   mc->mc_xcursor =3D mx;
>>
>>
>>
>>
>>
>>
>
> --
>   -- Howard Chu
>   CTO, Symas Corp.           http://www.symas.com
>   Director, Highland Sun     http://highlandsun.com/hyc/
>   Chief Architect, OpenLDAP  http://www.openldap.org/project/
>

--001a113602ac48c9b00511a317b0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p dir=3D"ltr">Hm, in some case valgrind was reported as I noticed, sure 10=
1%.</p>
<p dir=3D"ltr">Leonid</p>
<div class=3D"gmail_quote">18.03.2015 23:12 =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=
=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C &quot;Howard Chu&quot; &lt;<a hr=
ef=3D"mailto:hyc@symas.com";>hyc@symas.com</a>&gt; =D0=BD=D0=B0=D0=BF=D0=B8=
=D1=81=D0=B0=D0=BB:<br type=3D"attribution"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">=
<a href=3D"mailto:leo@yuriev.ru"; target=3D"_blank">leo@yuriev.ru</a> wrote:=
<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
As far as I remember this was fixed in ReOpenLDAP at January.<br>
Valgrind was reporting &#39;using uninitialized&#39;.<br>
</blockquote>
<br>
Not happening here. mdb_cursor_first() always initializes mc_ki.<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
<br>
Leonid.<br>
<br>
@@ -7301,6 +7551,7 @@ mdb_cursor_init(MDB_cursor *mc, MDB_txn *txn,<br>
MDB_dbi dbi, MDB_xcursor *mx)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mc-&gt;mc_top =3D 0;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mc-&gt;mc_pg[0] =3D 0;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mc-&gt;mc_flags =3D 0;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0mc-&gt;mc_ki[0] =3D 0;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (txn-&gt;mt_dbs[dbi].md_flags &amp; M=
DB_DUPSORT) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mdb_tassert(=
txn, mx !=3D NULL);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mc-&gt;mc_xc=
ursor =3D mx;<br>
<br>
<br>
<br>
<br>
<br>
</blockquote>
<br>
<br>
-- <br>
=C2=A0 -- Howard Chu<br>
=C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"=
http://www.symas.com"; target=3D"_blank">http://www.symas.com</a><br>
=C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland=
sun.com/hyc/" target=3D"_blank">http://highlandsun.com/hyc/</a><br>
=C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p=
roject/" target=3D"_blank">http://www.openldap.org/<u></u>project/</a><br>
</blockquote></div>

--001a113602ac48c9b00511a317b0--