[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5



--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Howard Chu <hyc@symas.com> writes:
> Jan Synacek wrote:
>> Howard Chu <hyc@symas.com> writes:
>>> jsynacek@redhat.com wrote:
>>>> Full_Name: Jan Synacek
>>>> Version: 2.4.40
>>>> OS: GNU/Linux
>>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-=
libdb-detection-with-gcc-5.patch
>>>> Submission from: (NULL) (94.112.188.81)
>>>>
>>>>
>>>> The old cpp version generated:
>>>> __db_version 5
>>>>
>>>> Configure then correctly picked up the version, since it greps for
>>>> "__db_version".
>>>>
>>>> The new output:
>>>> __db_version
>>>>               5
>>>>
>>>> Grepping no longer works and configure fails.
>>>>
>>>> Running cpp with -P (inhibit linemarkers generation) fixes this when u=
sing gcc
>>>> 5.
>>>> Behavior with older versions of gcc is not changed.
>>>
>>> Your patch is simple enough but frankly this sounds like a bug in gcc
>>> 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle
>>> of lines, or inserting line breaks arbitrarily.
>>
>> Yes, probably. But in the meantime, I needed the package to build, so I
>> wrote this patch.
>
> Please file a bug with the gcc project and followup here with a link to=20
> that bug, for future reference. Thanks.

Filed as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D65037.

> Adding this patch to git master.

Thank you,
=2D-=20
Jan Synacek
Software Engineer, Red Hat

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJU3GWXAAoJEL3BmMJQOtjB6HQQAKF6PH2e6OACvDZCAmCRj4qG
OT/izonRts5+ZEN645TB6oPjTN1hU43/Z/+W7eZQBQoTfQrngTzBwfAC3deFfFXU
vhwf+oZR3vTsPjGev5EwM+vl7OCXN5AYhU1JNkeXM65cVQsZHWHLTIjkVImodXSs
Gl258ydoURg29F1DNNfs4IA4ImpTuVZ9SZBLg7XCyJBN7Refgrbie7xpevkUh/5o
ctvN4AQpUese60GE+OKiYhnyViG/pzxamMdKyOtbf5AwN+4u0HdndUqPU6iJHEQ6
66D8iJsrQgBH0dl8ggX8uQKAoq+8Pkf3hs339NUrEOAk6O91lixSWTV4UQsAJK9q
0aGMDc1f0JcNDFq1ycCcHnnJ+TbEJRi/s/RmD1Ku87vGXpYTzXUbYZE8S5pRlkLl
Y5Nz0vfp76j9GvfFwrsKtvYBQAStWmV/HVeW5DbVXzRWE71StVeGfHOLRxViPoBp
3u2jaArPUMpA+ZgYfBZ7HMMvchBhgTW+f/nnZCudCVukWdd/VIK/JSe/r3q5SWv5
9QVnUy9er0t4yMsH+waSRCgRZ0BR14e7YNzPfzaqEIeFb/k5bbVtdAEhkjIREMHT
8oSF2/K+tCORx0lqpxoXZfjVEGAQUkobw/a9ABNnoUYeuy+/9nIkp970PK48AsCC
wEULvjRGsq9wvJorGDJI
=k/xN
-----END PGP SIGNATURE-----
--=-=-=--