[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5



--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Howard Chu <hyc@symas.com> writes:
> jsynacek@redhat.com wrote:
>> Full_Name: Jan Synacek
>> Version: 2.4.40
>> OS: GNU/Linux
>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-li=
bdb-detection-with-gcc-5.patch
>> Submission from: (NULL) (94.112.188.81)
>>
>>
>> The old cpp version generated:
>> __db_version 5
>>
>> Configure then correctly picked up the version, since it greps for
>> "__db_version".
>>
>> The new output:
>> __db_version
>>              5
>>
>> Grepping no longer works and configure fails.
>>
>> Running cpp with -P (inhibit linemarkers generation) fixes this when usi=
ng gcc
>> 5.
>> Behavior with older versions of gcc is not changed.
>
> Your patch is simple enough but frankly this sounds like a bug in gcc=20
> 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle=20
> of lines, or inserting line breaks arbitrarily.

Yes, probably. But in the meantime, I needed the package to build, so I
wrote this patch.

Cheers,
=2D-=20
Jan Synacek
Software Engineer, Red Hat

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJU22YfAAoJEL3BmMJQOtjBgz0P/0C6vOFzNeDmB/6gJApRB97j
qQ+eAfs+VVi1nzanutQUZWIHM8F1wFFUm1ULp76z8dkxrquI9VSpTzWSj2kMPMqY
iGZfK6fRM84Weog2iCR9LoVqXrNCkih1pOi3SBaQE8pLxZh0iLCg5ZEW3QEgoVam
UMQz0fU5fFKtvKB85Xcy02drn64dTSn5zyF59H0CgVCTC3GBYP/tR2qp//ZPb2jj
WsOMdSzx9ENf56Y/r6fmMRpKN3+c8jLHf7/zbStDIgVnCv6Haf8bLevgSYYejkus
Av5U88rM9proraf6DvjwpJFfk6OCzvVo0eOcE63orw+uHyYQz/vWCLaK4/Wwo1e/
84MekmHm1G9pQMpnrgOkUqQv/MYVQpeIgrL29DZC4y4nDa68iL7+WdNqova3s5ST
6onQTdIR8YBwVRXAfnV00SmJAEslzouhEH5MF7mcLCI+/06EnaKzqtMuTsQZvC1I
9oucRZRgdnax3jTyzDwyvxvei5/yvIESvj3NOx2vq35NxE2vqSpRqIGVucDM4cnN
HVzk7fd6nFGhG9ZKWgv+2+kz6lZlH+3duIR0nJydgUJJPlRS8NxysNw439Q+Wu2D
ql+Vfl9BglSrCwiE6+QrVmE9W5PLj1/I5AgE6Wrdl6zrAxYI2fj7LgiavM8tmWIp
RvUpCjFNkI6AiD2KmmpV
=bSRG
-----END PGP SIGNATURE-----
--=-=-=--