[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8018) a lot of warnings building with -Wall

Leonid Yuriev wrote:
> Yes of course, all warnings could be hushed by compiler options, but
> this also hides the real mistakes.
> So, I prefer fix the warnings, instead of disable gcc/clang features.
> Please review attached patchset and merge.

Your patch assumes CPP features that are not guaranteed to be present. 
Rejecting this patchset.

Learn more about how OpenLDAP software is built and why.
> Leonid.
> ---
> The attached files is derived from OpenLDAP Software. All of the
> modifications
> to OpenLDAP Software represented in the following patch(es) were
> developed by
> Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned
> rights
> and/or interest in this work to any party. I, Leonid Yuriev am
> authorized by
> Peter-Service LLC, my employer, to release this work under the following
> terms.
> Peter-Service LLC hereby places the following modifications to OpenLDAP
> Software
> (and only these modifications) into the public domain. Hence, these
> modifications may be freely used and/or redistributed for any purpose
> with or without attribution and/or other notice

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/