[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
Re: (ITS#8011) few mistakes in lmdb-backend
Ð?еонид ЮÑ?Ñ?ев wrote:
> Updated.
> Please pickup.
> diff --git a/servers/slapd/back-mdb/dn2id.c b/servers/slapd/back-mdb/dn2id.c
> index 41c4758..0890bce 100644
> --- a/servers/slapd/back-mdb/dn2id.c
> +++ b/servers/slapd/back-mdb/dn2id.c
> @@ -746,7 +746,8 @@ mdb_idscopes(
> /* remember our chain of parents */
> id2.mid = id;
> id2.mval = data;
> - mdb_id2l_insert( isc->sctmp, &id2 );
> + rc = mdb_id2l_insert( isc->sctmp, &id2 );
> + assert(rc == 0);
> }
> ptr = data.mv_data;
> ptr += data.mv_size - sizeof(ID);
Unnecessary, the total number of parents is constrained by the max
length of a DN which is 8192 bytes. A maximum depth DN (max number of
shortest possible RDNs) will always fit in sctmp.
I will commit the remainder of the patch.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/