[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8013) SIGSEGV in test_filter()



hyc@symas.com wrote:
> Leonid Yuriev wrote:
>>
>> 04.01.2015 02:47, Howard Chu wrote:
>>> The patch is wrong. syncprov_matchops can be called twice for the same
>>> operation; toggling the flag where you've placed it means the filter
>>> will be incorrect on the 2nd invocation as well as on all subsequent
>>> invocations.
>>
>> Ok, but found another case.
>> The ss->s_op->ors_filter may be updated immediately after the s_mutex
>> released.
>
> Seems like the simpler fix then is to keep the mutex held until after
> test_filter finishes.

Fixed in master.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/