[Date Prev][Date Next] [Chronological] [Thread] [Top]

Fwd: (ITS#7994) [LMDB] Feature Request: Access to current transaction ID.



--f46d0434c0ba9e39c905097be220
Content-Type: text/plain; charset=UTF-8

I typedef'd MDB_txnid_t at the top of lmdb.h. The patch also tweaks
MDB_envinfo.

On Fri, Dec 5, 2014 at 11:58 AM, Howard Chu <hyc@symas.com> wrote:
>
> Thanks. There's a slight problem with the patch, your function returns
> MDB_txnid_t but that is a private typedef in mdb.c. It is not defined in
> lmdb.h, so no one will be able to compile and use this code.
>
> Easiest change would be to just return size_t, like MDB_envinfo uses.
>

--f46d0434c0ba9e39c905097be220
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><br><div dir=3D"ltr">I typedef&=
#39;d MDB_txnid_t at the top of lmdb.h. The patch also tweaks MDB_envinfo.<=
span class=3D""><div><br></div><div><div class=3D"gmail_extra"><div class=
=3D"gmail_quote">On Fri, Dec 5, 2014 at 11:58 AM, Howard Chu <span dir=3D"l=
tr">&lt;<a href=3D"mailto:hyc@symas.com"; target=3D"_blank">hyc@symas.com</a=
>&gt;</span> wrote:<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks. There&#39;s a slight problem with the patch, your function returns =
MDB_txnid_t but that is a private typedef in mdb.c. It is not defined in lm=
db.h, so no one will be able to compile and use this code.<br>
<br>
Easiest change would be to just return size_t, like MDB_envinfo uses.<span>=
<font color=3D"#888888"><br></font></span></blockquote></div></div></div></=
span></div>
</div><br></div>

--f46d0434c0ba9e39c905097be220--