[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7976) Bug in syncrepl.c short-circuits overlay stack cleanup

mwarren@symas.com wrote:
> Full_Name: Mark Warren
> Version: 2.4.32
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (
> via Howard:
> "The bug is syncrepl.c lines 2036-2038. Returning LDAP_SUCCESS here
> short-circuits the overlay stack and *doesn't* call the cleanup handlers."
> Note: The line numbers are skewed as we're working with an older version.

On further analysis, it appears the patch is not needed in current code. It 
seems the problem (an incoming mod whose entryCSN matches the existing 
entryCSN of the target entry) was already avoided by the patch for ITS#7427, 
which was released in 2.4.34.

Definitely unable to reproduce the issue in 2.4.40.
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/