Re: (ITS#7960) [LMDB] wrong pointer used in mdb_cassert()

[jcd@tribudubois.net]

Le 10/03/2014 10:19 PM, Howard Chu a =E9crit :
> jcd@tribudubois.net wrote:
>> Full_Name: Jean-Christophe Dubois
>> Version: 2.4.40
>> OS: Linux
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (78.235.240.156)
>>
>>
>> In mdb_node_move() csrc is passed to mdb_cassert() at line 7396 when=20
>> it seems it
>> should be cdst (as the operation is on cdst).
>>
>> https://gitorious.org/mdb/mdb/source/56c2c160be19c555e4c42e459c8608ffa=
ae7b150:libraries/liblmdb/mdb.c#L7396=20
>>
>
> Irrelevant. The cursor is only passed to provide an env pointer, and=20
> both cursors point to the same env. Closing this ITS.

Right. It is just that it would be nicer/more logical as it is not clear=20
beforehand what the pointer is passed for.

An who knows what additional thing could be done in mdb_cassert in the=20
future.

JC

>>
>> Patch available at URL below:
>>
>> https://github.com/jcdubois/lmdb/commit/41ed03c4584ac46dc233dcf60f93ad=
db09962093=20
>>
>>
>> JC
>>
>>
>
>