[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7954) [LMDB] fix uninitialize struct member.

Jean-Christophe DUBOIS wrote:
> Le 10/02/2014 10:41 PM, Howard Chu a écrit :
>> jcd@tribudubois.net wrote:
>>> Full_Name: Jean-Christophe Dubois
>>> Version: 2.4.40
>>> OS: Linux
>>> URL: ftp://ftp.openldap.org/incoming/
>>> Submission from: (NULL) (78.235.240.156)
>>>
>>>
>>> In the mdb_env_cwalk() function the mc_flags  member of the "mc"
>>> MDB_cursor
>>> instance is not initialized.
>>>
>>> But in the mdb_page_search_root() called a bit later (line 8407) this
>>> flag will
>>> be updated from this uninitialized value.
>>>
>>> The mc_flags member needs to be initialized to a known value.
>>
>> The mc_flags member is never referenced again, so this is irrelevant.
>
> It is referenced here:
>
> https://gitorious.org/mdb/mdb/source/61dd017808f66ada27e89c58bc9567d5b2ade884:libraries/liblmdb/mdb.c#L5057

Yes. But, as I said already, it is never referenced again.
>
> This function(mdb_page_search_root()) is called from mdb_env_cwalk()
> with a reference to mc. and mc_flages is not initialized.

Irrelevant.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/