Re: (ITS#7954) [LMDB] fix uninitialize struct member.

[jcd@tribudubois.net]

Le 10/02/2014 10:41 PM, Howard Chu a =E9crit :
> jcd@tribudubois.net wrote:
>> Full_Name: Jean-Christophe Dubois
>> Version: 2.4.40
>> OS: Linux
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (78.235.240.156)
>>
>>
>> In the mdb_env_cwalk() function the mc_flags  member of the "mc"=20
>> MDB_cursor
>> instance is not initialized.
>>
>> But in the mdb_page_search_root() called a bit later (line 8407) this=20
>> flag will
>> be updated from this uninitialized value.
>>
>> The mc_flags member needs to be initialized to a known value.
>
> The mc_flags member is never referenced again, so this is irrelevant.

It is referenced here:

https://gitorious.org/mdb/mdb/source/61dd017808f66ada27e89c58bc9567d5b2ad=
e884:libraries/liblmdb/mdb.c#L5057

This function(mdb_page_search_root()) is called from mdb_env_cwalk()=20
with a reference to mc. and mc_flages is not initialized.

JC

>>
>> Patch available at URL below:
>>
>> https://github.com/jcdubois/lmdb/commit/57d0d380a18957245c8a011e735649=
09966eb399=20
>>
>>
>> JC
>>
>>
>
>