[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7857) let openldap build against the bionic libc

tux_mind@monumentmail.com wrote:
> Full_Name: tux_mind
> Version: lastest from git
> OS: gentoo GNU/Linux
> URL: https://github.com/tux-mind/platform_external_openldap
> Submission from: (NULL) (
> hello guys.
> i've modified a little your project to let it build against the bionic libc (
> the one used in android ).
> please let me known if you can merge this into the upstream project.
> modified sources can be found here:
> https://github.com/tux-mind/platform_external_openldap
> my changes are the last 3 of these commits:
> https://github.com/tux-mind/platform_external_openldap/commits/master

"added generated files" - No. Don't be silly.

The last time I compiled OpenLDAP for Android, I don't recall needing any 
#include patches. (That was for Froyo, a few years ago now.) I don't have a 
current dev system to check these changes.

The reason those generated files are generated is because those 
platform-specific features are known to change. E.g., 64 bit Android devices 
are coming out soon, and hardcoding things for 32 bit would be a mistake.

Including an Android.mk file in our distribution would require us to maintain 
it in parallel with our regular Makefiles, forever after. We will not do 
redundant support work, nor is it necessary. The standard OpenLDAP Makefiles 
work fine to create Android binaries.

Rejecting these patches.
> thanks for your attention

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/