(ITS#7831) Double Free in autogroup.c

[mwarren@symas.com]

Full_Name: Mark Warren
Version: 2.4.38
OS: Ubuntu 12.04.4 LTS
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (12.70.80.130)


A double-free has been located in contrib/slapd-modules/autogroup/autogroup.c

Lines:
 1208 and 1215

Proposed solution:
 Remove Line 1215


diff --git a/contrib/slapd-modules/autogroup/autogroup.c
b/contrib/slapd-modules/autogroup/autogroup.c
index a977561..5bafe2f 100644
--- a/contrib/slapd-modules/autogroup/autogroup.c
+++ b/contrib/slapd-modules/autogroup/autogroup.c
@@ -1212,7 +1212,6 @@ autogroup_response( Operation *op, SlapReply *rs )
 
                                                                       
autogroup_add_group( op, agi, group_agd, NULL, &op->o_req_ndn, 1, 1);
 
-                                                                      
overlay_entry_release_ov( op, e, 0, on );
                                                                       
ldap_pvt_thread_mutex_unlock( &agi->agi_mutex );
                                                                        return
SLAP_CB_CONTINUE;
                                                                }