[Date Prev][Date Next] [Chronological] [Thread] [Top]

(ITS#7734) MDB_NORDAHEAD missing from valid flags bitfields



Full_Name: David Wilson
Version: LMDB 0.9.9
OS: 
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (178.238.153.20)


Unless I'm missing something, this new flag cannot be set during mdb_env_open(),
and since it is not in CHANGEABLE either, cannot be set with
mdb_env_set_flags()

commit dd0df21ce0a935955966aa7d3077d666741d027f
Author: David Wilson <dw@botanicus.net>
Date:   Mon Oct 28 01:28:00 2013 +0000

    Add MDB_NORDAHEAD to CHANGELESS.

diff --git a/lib/mdb.c b/lib/mdb.c
index 33be876..3ec7302 100644
--- a/lib/mdb.c
+++ b/lib/mdb.c
@@ -3929,7 +3929,7 @@ fail:
    * environment and re-opening it with the new flags.
    */
 #define CHANGEABLE  (MDB_NOSYNC|MDB_NOMETASYNC|MDB_MAPASYNC)
-#define   CHANGELESS 
(MDB_FIXEDMAP|MDB_NOSUBDIR|MDB_RDONLY|MDB_WRITEMAP|MDB_NOTLS|MDB_NOLOCK)
+#define   CHANGELESS 
(MDB_FIXEDMAP|MDB_NOSUBDIR|MDB_RDONLY|MDB_WRITEMAP|MDB_NOTLS|MDB_NOLOCK|MDB_NORDAHEAD)

 int
 mdb_env_open(MDB_env *env, const char *path, unsigned int flags, mdb_mode_t
mode)