[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7682) LMDB: [PATCH] mdb_env_copy should retry open() if O_DIRECT fails

sog@msg.com.mx wrote:
> Full_Name: Salvador Ortiz
> Version: 24
> OS: Linux
> URL: ftp://ftp.msg.com.mx/pub/varios/0001-In-mdb_env_copy-retry-open-if-O_DIRECT-fails.patch
> Submission from: (NULL) (
> If the OS defines O_DIRECT mdb_env_copy unconditionally uses it, but according
> to open(2): "Some  file  systems  may  not implement the flag and open() will
> fail with EINVAL if it is used."
> In this cases mdb_env_copy should retry without the flag.
> The attached patch implements that.
Thanks, applied.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/