[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7531) Syncrepl push delete operation does not recover when slave is unavailable

jsynacek@redhat.com wrote:
> On 02/27/2013 02:48 PM, jsynacek@redhat.com wrote:
>> On 02/27/2013 12:25 PM, jsynacek@redhat.com wrote:
>>> Full_Name: Jan Synacek
>>> Version: RE24 (7b03a58)
>>> OS: Linux - Fedora 18
>>> URL: ftp://ftp.openldap.org/incoming/jsynacek-reproducer.tar.gz
>>> Submission from: (NULL) (209.132.186.34)
>>>
>>>
>>> The setup is a master with an ldap backend and a slave consumer. If the master
>>> is running and slave is not, delete operation results in the master being
>>> stuck.
>>>
>>> Steps to reproduce:
>>> 1. Start master.
>>> 2. Add the example ldif.
>>> 3. Delete one of the test org units.
>>> 4. Observe the error.
>>>
>>> I would expect the master to honor the retry setting.
>>>
>>
>> During the reproduction, it may be necessary to first have both master and slave
>> running, delete a testing test org unit (so the first replication is
>> successful), stop the slave and then continue to step 3.
>>
>
> URL:
> ftp://ftp.openldap.org/incoming/jsynacek-20130103-syncrepl-retry.patch

This patch is clearly unacceptable. Your goto obviously skips over two _free() 
invocations, thus introducing a memory leak.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/