[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7415) Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

Kurt@OpenLDAP.org wrote:
> You miss the fact that we encourage deployers of OpenLDAP Software, who we
recommend build OpenLDAP Software from source, run 'make test' before they
'make install'. We don't want these deployers to have false positives, such as
would be likely caused if we added such environmental variables.
> For those doing automated checks, such as those who do construct packages,
they can have local patches to their hearts content. Likewise for developers.
> So, if it was up to me, I would reject your patch as, IMO, it's in
appropriate for our source distributions. I suspect Howard will chime in
sooner or later.

I think you've already covered the points. I have plenty of checks like this 
in my local source tree, but I see no reason to embed OS and platform-specific 
stuff into the distributed source. I believe it would lend a false sense of 
security, particularly when you're on a platform that ignores these variables, 
but you aren't aware of the fact.

It is always the developers' responsibility to know how their own development 
environment works, and to tweak it to suit their development efforts.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/