[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7415) Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012/10/12 Kurt Zeilenga <Kurt@openldap.org>:
> You miss the fact that we encourage deployers of OpenLDAP Software, who we recommend build OpenLDAP Software from source, run 'make test' before they 'make install'.   We don't want these deployers to have false positives, such as would be likely caused if we added such environmental variables.

It is your own opinion, right? Have experiences in this regard? I do
not. I personally run make test on openldap with Ubuntu 4.12, Fedora
17 and RHEL6 and my patch without any problem (good for openldap :=)
). And many other projects, for example,  git hat has a very extensive
test suite, use MALLOC_CHECK as in my patch, integrated in a test

However, I will not insist further on a trivial patch. Also because
this discussion gave me the opportunity to investigate better the
issue, and I'll just patch for FreeBSD my software. So, thank you
anyway for the useful observations.

> For those doing automated checks, such as those who do construct packages, they can have local patches to their hearts content.  Likewise for developers.
> So, if it was up to me, I would reject your patch as, IMO, it's in appropriate for our source distributions.  I suspect Howard will chime in sooner or later.
> -- Kurt