(ITS#7373) [PATCH] TLS: do not reuse tls_session if hostname check fails

[jvcelak@redhat.com]

Full_Name: Jan Vcelak
Version: git master
OS: Linux
URL: ftp://ftp.openldap.org/incoming/jvcelak-20120828-tls-do-not-reuse-tls_session-if-hostname-check-fails.patch
Submission from: (NULL) (209.132.186.34)


If multiple URIs are specified when creating LDAP connection, the connection to
the first one succeeds but the hostname verification fails, *tls_session is not
dropped, but reused when connecting to the second server.

This is a problem with Mozilla NSS backend because another handshake cannot be
performed on the same file descriptor and SSL_ForceHandshake() will hang. From
this reason, hostname checking was moved into ldap_int_tls_connect() before
connection error handling.

I have verified for all backends (OpenSSL, GnuTLS, MoznSSS) that this fix does
not break hostname verification and that this bug does not present.

Original report: https://bugzilla.redhat.com/show_bug.cgi?id=843056


The attached file is derived from OpenLDAP Software. All of the modifications to
OpenLDAP Software represented in the following patch(es) were developed by Red
Hat. Red Hat has not assigned rights and/or interest in this work to any party.
I, Jan Vcelak am authorized by Red Hat, my employer, to release this work under
the following terms. 

Red Hat hereby place the following modifications to OpenLDAP Software (and only
these modifications) into the public domain. Hence, these modifications may be
freely used and/or redistributed for any purpose with or without attribution
and/or other notice.