[Date Prev][Date Next] [Chronological] [Thread] [Top]

(ITS#7289) Mozilla NSS: cipher suite selection by name may be ignored

Full_Name: Tim Strobell
Version: HEAD
URL: ftp://ftp.openldap.org/incoming/tim-strobell-2012060501.patch
Submission from: (NULL) (2001:480:20:112:210:18ff:fe19:b000)

Under certain circumstances, cipher suite selection by name ("OpenSSL name") may
inadvertently cause any additional named cipher selections to be ignored.

In tls_m.c:625...

    for (i=0; i<ciphernum; i++) {
        if (!strcmp(ciphers_def[i].ossl_name, cipher) &&
             cipher_list[1] != -1)       
                 cipher_list[i] = action;

The index into cipher_list on line 627 is 1 (one) but should be i (eye).
Any cipher selection that disables RC2-CBC-MD5 (cipher_list[1]) will not
add/subtract/disable (action = 1, 0, -1 resp.) any further named ciphers in the