[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7182) back-ldap monitoring improvements

hyc@symas.com wrote:
> Ondrej Kuznik wrote:
>> Hash: SHA1
>> On 03/27/2012 01:30 PM, hyc@symas.com wrote:
>>> ondrej.kuznik@acision.com wrote:
>>>> Full_Name: Ondrej Kuznik
>>>> Version: HEAD
>>>> OS: Linux
>>> I have pushed patches 1-3 to git master. patch 4 seems to require additional work.
>> I have reworked the remaining patches according to your suggestions, the
>> resulting patchset is at:
>> ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20120329-back-ldap-monitoring-v3.tgz
> Committed to master, thanks for the patches.

See ITS#7225.

Even after the SEGV is patched, the pcache slapd fails to start in test020 
because the monitor calls are unable to register their entries. Something is 
wrong in your initialization code.

Also, you're using monitor_entry_stub() directly in the back-ldap code. It is 
forbidden for modules to directly reference each other's symbols. If you need 
this function, add it to monitor_extra_t first and call it through there.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/