[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7181) off by 2 error in --ldif-wrap

Hallvard B Furuseth wrote:
>   On Sat, 25 Feb 2012 00:19:11 GMT, hyc@symas.com wrote:
>> h.b.furuseth@usit.uio.no wrote:
>>> The client option --ldif-wrap=N outputs lines of N+2 columns.
>>> E.g. 'ldapsearch -o ldif-wrap=20 ...'  gives 22-column output.
>> Not a bug. See libldap/ldif.c:490.
>   That's old an internal matter, exposed as default wrap width 78
>   instead of rfc2849's max 76.
>   This ITS is about the new --ldif-wrap option.  The tools can just
>   subtract 2 from the input value and otherwise keep the current code.

But then the tools will be wrong when we fix the library.

>   (I do think we should throw away the old bug-compat code and
>   fix the default 78 to 76, but not in RE24.  And I note the bug-
>   compat comment claims it's off by 1 while it's actually 2:)

Sure, I'd like to throw that all out too. But in the meantime, I'd rather not 
have the tools' functionality change twice over the same issue. (I.e., fix the 
tools now, then fix the libraries later and have to re-fix the tools.)

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/