[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6883) Improved Makefiles for contrib modules

 On Thu, 16 Feb 2012 11:38:13 GMT, bgmilne@staff.telkomsa.net wrote:
> Please let me know how we can get this patch merged.

 OpenLDAP needs more active developers...  Anyway:

 It should remove GNU Make dependencies, not introduce them: Only use
 '$<' in inference rules, not explicit target rules (like ITS#7160).
 Drop '%.x: %.y' rules.  I've scribbled a draft for that at repo
 <http://folk.uio.no/hbf/OpenLDAP/openldap.git>, branch its6883.
 (Not tested, and I need to install a non-Gnu Make to test with too.)

 I'll work at it later, but don't quite know when.  Unless you
 beat me to it.

 Also I suppose '+=' should go away.  Which I would mean move what
 is added to a new variable so the user can easily say things like
   make CPPFLAGS='-Dwhatever $(DEFS)'.
 Or maybe use

 LT_CPPFLAGS= ..whatever $(CPPFLAGS) ...

 like e.g. slapd/overlays/Makefile ends up doing.  THat one has an
 awful number of Make variables and is fairly unreadable to me,
 probably to satisfy autoconf & co.  But a few more vars seems useful.