[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7149) Back-perl, Back-shell and Binary Data

jiashun.qian@atos.net wrote:
> Full_Name: Jiashun QIAN
> Version: 2.4.28
> OS: CentOS 6
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (
> The backend shell and the backend perl can't handle some binary data.
> This occurs only with MODIFY because when ADD the binary data is encoded in
> base64 but not MODIFY.
> The binary data is truncated when if it contains \0. In fact, data is stored in
> a linked list of char * and treated as characters.
> ---
> servers/slapd/back-perl/modify.c
> XPUSHs(sv_2mortal(newSVpv( mods->sm_values[i].bv_val, 0 )));
> ---
> The type of mods->sm_values[i].bv_val is char*.
> To handle the binary data, for back-perl, just change another function mXPUSHp,
> which we can put the exacte length of mod->sm_values[i].bv_val as parameter,
> it's mod->sm_values[i].bv_len. So it will push the total data.

That is obviously the wrong approach. Since these backends communicate using 
LDIF, binary values should be base64 encoded according to the LDIF rules.

Thanks for the patch, but we can't merge it since the provided solution is wrong.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/