[Date Prev][Date Next] [Chronological] [Thread] [Top]

RE: (ITS#6828) TLS fails to start when LDAP_OPT_CONNECT_ASYNC is used

Thanks Howard. I pulled your change out of GIT and tested it, and it works fine for me.

However, just as an FYI, this line in open.c results in a "suggest parentheses around && within ||" warning from gcc with the compiler options that we use to compile our OpenLDAP port, and that in turn results in a build failure (since we use -Werror):

        if (rc == 0 && ld->ld_options.ldo_tls_mode == LDAP_OPT_X_TLS_HARD ||
                strcmp( srv->lud_scheme, "ldaps" ) == 0 )

The parentheses that I had in that line in my patch avoided that.