[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6657) back-sql segfault in backsql_search

Timo Teräs wrote:
> On 06/14/2011 08:24 AM, hyc@symas.com wrote:
>> On Tue, Jun 14, 2011 at 08:16:18AM +0300, Timo Ter?s wrote:
>>> On 06/13/2011 11:56 PM, Howard Chu wrote:
>>>> timo.teras@iki.fi wrote:
>>>>> ITS#6691 seems to be same issue.
>>>>>
>>>>> I have a patch to fix this.
>>>>>
>>>>> It's available at:
>>>>> http://git.alpinelinux.org/cgit/aports.git/plain/main/openldap/openldap-back-sql-fix-64bit.patch
>>>>>
>>>> Thanks for the patch, now in git master.
>>>
>>> Good. Though, it would have been polite to credit me as the commit author.
>>
>> You were credited in the release branch.
>
> Oh, right.
>
>> In the future use git format-patch and things like this won't get overlooked.
>
> I did not have the git tree available on the 64-bit machine I was given
> to work with. And at that point I did not even know which version
> control you used.

You are expected to have read this already before submitting code:
http://www.openldap.org/devel/contributing.html

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/