[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6883) Improved Makefiles for contrib modules



--On Tuesday, March 29, 2011 3:25 PM +0000 bgmilne@staff.telkomsa.net wrote:

> Full_Name: Buchan Milne
> Version: 2.4.25
> OS: Linux
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (196.25.124.16)
>
>
> While the code in contrib is not supported, some overlays provide make
> files, some don't, and there were variations in a lot of the make files
> (e.g. use of DESTDIR or not).
>
> In order to add make files for overlays that don't have them, improve the
> consistency of the make files between overlays that had them, and to
> provide some basic sanity testing in a 'test' target, I have created the
> patch at:
> http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/openldap/curre
> nt/SOURCES/openldap-2.4.25-contrib-makefiles-with-tests.patch?revision=64
> 8744&view=markup
>
> The patch is against 2.4.25, but should apply to master (except that
> there two additional overlays are present in master). Where feasible I
> have retained the majority of an existing make file, in other cases,
> where modifications would exceed the original content, I have replaced
> existing make files wholesale.
>
> The attached patch file is derived from OpenLDAP Software. All of the
> modifications to OpenLDAP Software represented in the following patch(es)
> were developed by Buchan Milne  (bgmilne@staff.telkomsa.net). I have not
> assigned rights and/or interest in this work to any party.

Hi Buchan,

Can you make the patch available via git-format-patch?

Thanks,
Quanah

--

Quanah Gibson-Mount
Sr. Member of Technical Staff
Zimbra, Inc
A Division of VMware, Inc.
--------------------
Zimbra ::  the leader in open source messaging and collaboration