[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6238) contrib: lastbind overlay to record timestamp of last successful bind



Howard Chu wrote:
> Yes, several objections. Post diffs that can be applied by the "patch"
> command, not the complete file. 

See below.

> If you're going to add more rules, make
> them conform to the standard Makefiles. E.g. the correct macro is
> "prefix" not "PREFIX".

Not consequently used in contrib/slapd-modules/. Therefore I didn't know this.

Ciao, Michael.

Index: Makefile
===================================================================
RCS file: /repo/OpenLDAP/pkg/ldap/contrib/slapd-modules/lastbind/Makefile,v
retrieving revision 1.2.2.2
diff -u -r1.2.2.2 Makefile
--- Makefile	4 Feb 2011 23:39:17 -0000	1.2.2.2
+++ Makefile	15 Feb 2011 14:48:30 -0000
@@ -10,6 +10,8 @@
 # top-level directory of the distribution or, alternatively, at
 # <http://www.OpenLDAP.org/license.html>.

+prefix=/usr/local
+
 CPPFLAGS+=-I../../../include -I../../../servers/slapd
 CPPFLAGS+=-DSLAPD_OVER_LASTBIND=SLAPD_MOD_DYNAMIC
 #LIBTOOL=libtool
@@ -23,7 +25,12 @@

 lastbind.la:    lastbind.lo
 	$(LIBTOOL) --mode=link $(CC) -version-info 0:0:0 \
-		   -rpath $(PREFIX)/lib -module -o $@ $?
+		   -rpath $(prefix)/lib -module -o $@ $?

 clean:
 	rm -rf lastbind.lo lastbind.la lastbind.o .libs/
+
+install: lastbind.la
+	mkdir -p $(prefix)/libexec/openldap
+	$(LIBTOOL) --mode=install cp lastbind.la $(prefix)/libexec/openldap
+	$(LIBTOOL) --finish $(prefix)/libexec/openldap