[Date Prev][Date Next]
Re: (ITS#6238) contrib: lastbind overlay to record timestamp of last successful bind
- To: openldap-its@OpenLDAP.org
- Subject: Re: (ITS#6238) contrib: lastbind overlay to record timestamp of last successful bind
- From: email@example.com
- Date: Mon, 7 Feb 2011 14:31:37 GMT
- Auto-submitted: auto-generated (OpenLDAP-ITS)
Michael Ströder wrote:
> firstname.lastname@example.org wrote:
>> email@example.com wrote:
>>> Could we have this overlay in contrib/ shipped with 2.4.24?
>>> That would be really nice.
>>> I've tested it with 2.4.23 and it still seems to work.
>> Committed with changes in HEAD.
> Also in RE24. Thanks a lot!
> Any objections adding a slightly more complete Makefile (see attachment)?
Yes, several objections. Post diffs that can be applied by the "patch"
command, not the complete file. If you're going to add more rules, make them
conform to the standard Makefiles. E.g. the correct macro is "prefix" not
"PREFIX". Post diffs that actually work, your "OPT" macro is never referenced
anywhere else in the Makefile so it's useless. The default prefix is always
/usr/local. You can use whatever prefix you like in your personal copy, but
stick with the defaults on anything you submit to us.
> Ciao, Michael.
> # Copyright 2009 Jonathan Clarke<firstname.lastname@example.org>.
> # All rights reserved.
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted only as authorized by the OpenLDAP
> # Public License.
> # A copy of this license is available in the file LICENSE in the
> # top-level directory of the distribution or, alternatively, at
> CPPFLAGS+=-I../../../include -I../../../servers/slapd
> OPT=-g -O2
> all: lastbind.la
> lastbind.lo: lastbind.c
> $(LIBTOOL) --mode=compile $(CC) $(CPPFLAGS) -Wall -c $?
> lastbind.la: lastbind.lo
> $(LIBTOOL) --mode=link $(CC) -version-info 0:0:0 \
> -rpath $(PREFIX)/lib -module -o $@ $?
> rm -rf lastbind.lo lastbind.la lastbind.o .libs/
> install: lastbind.la
> mkdir -p $(PREFIX)/libexec/openldap
> $(LIBTOOL) --mode=install cp lastbind.la $(PREFIX)/libexec/openldap
> $(LIBTOOL) --finish $(PREFIX)/libexec/openldap
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/