[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6820) void functions with return's



richton@nbcs.rutgers.edu wrote:
> Full_Name: Aaron Richton
> Version: RE24
> OS: irrelevant
> URL: 
> Submission from: (NULL) (128.6.31.135)
> 
> 
> ITS # 6814 patch has a couple void functions with returns; that's not legal.
> Patch below.
> 
> I also note that it looks like some functions are missing prototypes in RE24.
> That's only a warning to most compilers, but it might be nice to address that
> too.
> 
> --- servers/slapd/filter.c~     2011-02-01 11:34:06.062872000 -0500
> +++ servers/slapd/filter.c      2011-02-01 11:34:16.721012000 -0500
> @@ -586,7 +586,7 @@
>  void
>  filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
>  {
> -       return filter2bv_undef_x( op, f, 0, fstr );
> +       filter2bv_undef_x( op, f, 0, fstr );
>  }
>  
>  void
> @@ -848,7 +848,7 @@
>  void
>  filter2bv( Filter *f, struct berval *fstr )
>  {
> -       return filter2bv_undef( f, 0, fstr );
> +       filter2bv_undef( f, 0, fstr );
>  }

My fault, sorry.  Thanks, p.