[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6404) tests return success on failure



Reopening this ITS.

tests/scripts/test038-retcode rev 1.9 can be imported to RE24,
it's a mislabeled fix for this.


I would commit the following fix for test020-proxycache, except I'd
like to know why the test deliberately does 'exit 0' on some failures.
'exit 0' #1-4 are OK, but I do not understand the next 5 of them from:

  rev 1.34 (hyc) ITS#6152 add tests for cache refresh and Bind caching
  rev 1.35 (hyc) ITS#6152 test pwdModify

If nothing else, these success exits should first give a message
which clarifies that the condition which caused the exit is not a bug.
As in hunk #1 below.

Index: test020-proxycache
--- test020-proxycache	4 Jan 2011 23:43:43 -0000	1.40
+++ test020-proxycache	1 Feb 2011 09:39:19 -0000
@@ -153,5 +153,5 @@
 RC=$?
 if test $RC != 0 ; then
-	echo "Debug messages unavailable, test aborted..."
+	echo "Debug messages unavailable, remaining test skipped"
 	test $KILLSERVERS != no && kill -HUP $KILLPIDS && wait
 	exit 0
@@ -257,5 +257,5 @@
 	echo "ldapsearch should have failed!"
 	test $KILLSERVERS != no && kill -HUP $KILLPIDS
-	exit $RC
+	exit 1
 	;;
 4)
@@ -284,5 +284,5 @@
 	echo "ldapsearch should have failed!"
 	test $KILLSERVERS != no && kill -HUP $KILLPIDS
-	exit $RC
+	exit 1
 	;;
 4)
@@ -407,5 +407,5 @@
 	echo "ldapsearch should have failed!"
 	test $KILLSERVERS != no && kill -HUP $KILLPIDS
-	exit $RC
+	exit 1
 	;;
 4)
@@ -434,5 +434,5 @@
 	echo "ldapsearch should have failed!"
 	test $KILLSERVERS != no && kill -HUP $KILLPIDS
-	exit $RC
+	exit 1
 	;;
 4)

-- 
Hallvard