Re: (ITS#6792) rwm with broken config suppresses LDAP response

[masarati@aero.polimi.it]

masarati@aero.polimi.it wrote:
> h.b.furuseth@usit.uio.no wrote:
>> Full_Name: Hallvard B Furuseth
>> Version: RE24, HEAD
>> OS: Linux x86_64
>> URL: http://folk.uio.no/hbf/OpenLDAP/rwmhang-draft.txt
>> Submission from: (NULL) (193.157.201.147)
>> Submitted by: hallvard
>>
>>
>> rwm suppresses the LDAP response message if rwm_response() fails.
>> This hangs waiting for the response:
>>
>> include  servers/slapd/schema/core.schema
>> database monitor
>> overlay  rwm
>> rwm-rewriteEngine  on
>> rwm-rewriteContext matchedDN
>> # Rewrite to nonexistent $1 or broken DN
>> rwm-rewriteRule    ".*time.*" "cn=test,$1" :
>> rwm-rewriteRule    ".*"       "urgle"      :
>>
>> ldapcompare -x cn=hello,cn=time,cn=monitor l:x
>> ldapsearch  -xLLL -b   cn=hello,cn=monitor
>>
>> The enclosed patch seems to fix it, but I've only looked briefly at
>> what's going on.
> 
> Good catch; however, the problem might need a slightly different fix; in 
> fact, yours prevents rwm_response from aborting the operation by forcing 
> an "unwilling to perform" based on the contents of the referral/matched.

Sorry, I misread your patch; in fact, it's about setting sr_err as 
appropriate while letting the progess go on to the following hanlder, so 
it is correct to always return SLAP_CB_CONTINUE while eventually setting 
sr_err if needed by the rewrite engine.

p.