[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6716) syncprov sessionlog 'sl_mincsn' not assigned a value.

rein@OpenLDAP.org wrote:
> On 09.12.10 09.09, masarati@aero.polimi.it wrote:
>> I think the best (blind) fix consists in only performing that test if
>> sl_mincsn is assigned a value; something like
> I'm looking at an extended fix.  The problem with the current 
> implementation is that is assumes the entries arrives in CSN order, 
> which isn't necessarily true in a MMR configuration.
> My fix drops sl_mincsn, keeps the log queue in CSN order and compares 
> with the head entry.  It also wipes the log if it receives any changes 
> without CSN (i.e during refresh).
> There might still be a theoretical problem there, if the sid of an entry 
> in the log is not in the set sent by the consumer.  But since we know 
> they have the same number of CSNs this can only happen during initial 
> setup of a multi-master configuration.  In which case the admins real 
> problem is that he didn't bring the servers online in a controlled order..

OK, I'm not looking at this any more.  Thanks, p.