Re: (ITS#6737) slapmodify strangeness

[masarati@aero.polimi.it]

> Full_Name: Hallvard B Furuseth
> Version: HEAD
> OS:
> URL:
> Submission from: (NULL) (129.240.6.233)
> Submitted by: hallvard
>
>
> 'sid' in slapmodify.c is read uninitialized before it is written, at line
> 693:
>
> 	if ( rc == EXIT_SUCCESS && update_ctxcsn && !dryrun && sid !=
> SLAP_SYNC_SID_MAX
> + 1 ) {
>
> A loop _below_ that statement can set sid to the expected value:
>
> 	for ( sid = 0; sid <= SLAP_SYNC_SID_MAX; sid++ )
>
> Also slapmodify sets up but does not use variables opbuf and op.

slapdmodify(8) is the (nearly untested) result of non negligible cut'n'paste.

p.