[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6536) Autogroup overlay enhancement

raphael.ouazana@linagora.com wrote:
> Full_Name: Raphael Ouazana
> Version: 2.4.21
> OS: Linux
> URL: ftp://ftp.openldap.org/incoming/raphael-ouazana-autogroup-100427.patch
> Submission from: (NULL) (
> Hi,
> The attached patch allow the autogroup overlay to handle correctly the attr part
> of the URL ldap://dc=example,dc=com?attr?sub?(filter). Before this patch, the
> attr part was simply ignored. Now the group entry is populated by the values of
> the attribute attr in the resulting entries.
> Implementation details:
> Some cases (modify, delete) are harder to handle when you store values instead
> of dn. In this cases the overlay try to detect if groups have been modified and
> then simply refresh them. This can cause performance hits if the search
> specified by the URL deals with an important number of entries.
> Legal notice:
> This patch file is derived from OpenLDAP Software. All of the modifications to
> OpenLDAP Software represented in this following patch were developed by Raphael
> Ouazana raphael.ouazana@linagora.com. These modifications are not subject to
> any
> license of Linagora.
> The attached modifications to OpenLDAP Software are subject to the following
> notice:
> Copyright 2010 Raphael Ouazana, Linagora
> Redistribution and use in source and binary forms, with or without
> modification,
> are permitted only as authorized by the OpenLDAP Public License.

The code patch looks OK to me, but could you also provide a patch for the 
README file summarizing this new behavior? I'm not too keen on supporting 
groups of anything other than DNs in general, but I see the usefulness of it. 
However the potential performance hit can be quite a concern.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/