[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6432) PATCH: MozNSS crypto (tls_m.c) - support InitContext, improved PEM support

hyc@symas.com wrote:
> rmeggins@redhat.com wrote:
>> Any update on this?
> Sorry I must've missed your last reply, I thought we were still waiting on you.
> Why is pem_mod_name needed as an independent variable? Since it's const I 
> presume it will not be changing in the future?
I guess it doesn't really matter.  It may change if the PEM module 
decides to change its name, but that is not likely.
> (Not asking for a change here, just want to understand its purpose.)
> Actually, since it and pem_library are only used once each, I would probably 
> just #define it instead. But again, just want to know first how constant it 
> really is.
See above - it doesn't matter to me either, it could be #define'd or 
even hard coded in the module init string.  Just let me know.
> I've committed the patch as-is. If any other tweaks are needed let us know.
> Thanks for working on this.