(ITS#6256) segfault in syncrepl_add

[jonathan@phillipoux.net]

Full_Name: Jonathan Clarke
Version: RE24 and HEAD from today
OS: 
URL: ftp://ftp.openldap.org/incoming/jonathan-clarke-syncrepl-20090815.patch
Submission from: (NULL) (88.164.187.72)


syncinfo_free attempts:
sie->si_cookieState->cs_ref--

Although si_cookieState may be NULL.

When adding a syncrepl consumer (either through slapd.conf or online via
cn=config), if the syncrepl config line causes a parse error, syncinfo_free is
called and makes slapd segfault. Other paths through syncrepl_add may cause this
too.

The patch above corrects this.