[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5973) Syncrepl can update more than one csn value

rein@OpenLDAP.org wrote:
> Full_Name: Rein Tollevik
> Version: CVS HEAD
> OS: irrelevant
> URL:
> Submission from: (NULL) (
> Submitted by: rein
> Syncrepl can update more than one csn value in one operation, but only one can
> be passed to syncprov in the csn queue.  Syncprov should instead pick the
> updated values from the modify operation.

The syncrepl patch broke the CSN queue, which has caused out-of-order updates 
in test050. I have reverted it. Every write operation begins with a queued CSN 
and ends by graduating a CSN. You removed the enqueueing step, and so the 
queue contents were invalid.

> A patch that fixes this is coming.  This patch depends on the ITS#5972 patch,
> and is required for the new test058 to succeed.

test058 has the same number of errors with or without the syncrepl patch, so I 
don't think it was relevant to the issues you were addressing.

I'm still skeptical about the syncprov half of the patch. The two patches were 
actually unrelated, the syncprov patch takes effect regardless of the syncrepl 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/