Re: (ITS#5942) URI matching of "self" in add_syncrepl is incomplete

[hyc@symas.com]

Howard Chu wrote:
> hyc@symas.com wrote:
>> jclarke@linagora.com wrote:
>>> I saw the comment in the code that clarifies this behaviour. However, it's a
>>> surprising behaviour, and I think there is code to parse this kind of thing in
>>> the serverID detection now. Maybe it could be reused?
>
> Oops, never mind. I was thinking of the serverID code, and you're talking
> about the syncrepl code.
>
> I'll have to think a bit about why the two aren't behaving identically;
> probably they should both use the same code.
>
Ah right. For the serverID code, we're doing a liberal match because anything 
that matches the current name:port is obviously the current server, and we 
want it to be identified as such.

For syncrepl, we know full well that it may be the current server, but for 
whatever reason you may want to replicate against yourself anyway (e.g., 
against a different baseDN, etc...).

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/