[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5893) test scripts should stop immediately if slapd crashed



Howard Chu wrote:
> Pierangelo Masarati wrote:
>> hyc@symas.com wrote:
>>
>>> I saw that, but it seems that multiple -i options work.
>>> -i !xx  -i yy
>>
>> Yes, it works.  The test becomes waaaaaay too verbose, though.  It'd be
>> nicer to have the possibility to limit the error message to the first
>> occurrence, when it is intended.
> 
> Yes, I also patched slapd-bind.c in my tree, forgot to mention that:
> @@ -344,7 +348,7 @@
>              /* if ignore.. */
>              if ( first ) {
>                  /* only log if first occurrence */
> -                if ( force < 2 || first == 1 ) {
> +                if ( first == 1 ) {
>                      tester_ldap_error( ld, "ldap_sasl_bind_s", NULL );
>                  }
>                  rc = LDAP_SUCCESS;

I've added another modifier, "*", that makes testers ignore errors and 
only log the first occurrence.  I'm about to commit it.

p.


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Fax:     +39 0382 476497
Email:   ando@sys-net.it
-----------------------------------