[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5814) concurrent access to connections

Hallvard B Furuseth wrote:
> test036-meta-concurrency just crashed with fresh HEAD code.
> I suppose that's the same as this ITS.

Looks like.  However, now I thought my FIXME were little more than a 
precaution.  In fact, right now the only places where c_struct_state can 
be modified are protected by a mutex on connections_mutex; this should 
prevent changing the state of a connection during a connection_next() 
call.  Do you see a thread waiting on 
ldap_pvt_thread_mutex_lock( &connections_mutex ); at connection.c:427 or 
connection.c:514?  If that's the case, we probably need to move 
c->c_conn_state = SLAP_C_INACTIVE; inside the mutex in order to be able 
to safely assert in connection_next().  Is it worth?


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Fax:     +39 0382 476497
Email:   ando@sys-net.it