[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5764) addpartial patch

Pierangelo Masarati wrote:
> dhawes@vt.edu wrote:
>> Full_Name: David Hawes
>> Version: 2.4.12
>> OS: URL: ftp://ftp.openldap.org/incoming/david-hawes-081021.patch
>> Submission from: (NULL) (
>> This patch includes the following changes:
>> - -fPIC added to the Makefile for compilation on x86_64 systems.
>> - No longer use be_search() to retrieve the entry that is to be
>> compared.  Use
>> be_entry_get_rw() instead.
> You should probably use overlay_entry_get_ov() rather than
> be_entry_get_rw() from inside an overlay (AFAIR).

Okay, I'll make that change, thanks.

I notice that most overlays seem to use be_entry_get_rw(), and one
(translucent) uses both.  What is the reasoning to use one over the other?